Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow log to an existing run ID in MLflow with MLFlowLogger #12290

Merged
merged 22 commits into from Mar 27, 2022
Merged

Allow log to an existing run ID in MLflow with MLFlowLogger #12290

merged 22 commits into from Mar 27, 2022

Conversation

Kr4is
Copy link
Contributor

@Kr4is Kr4is commented Mar 10, 2022 •
edited

What does this PR do?

Currently MLflow logger is not able to use an existing run to upload new log information. This PR allows give a run_id to de MLflow logger constructor in order to use this existing run to log there the information. If the run_id doesn't exists a warning is shown informing about this and a new run is created, like the current MLflow logger constructor works.

Fixes #12287

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@Kr4is Kr4is changed the title Log artifacts to an existing run ID in MLflow Allow log artifacts to an existing run ID in MLflow Mar 10, 2022
@Kr4is Kr4is changed the title Allow log artifacts to an existing run ID in MLflow Allow log to an existing run ID in MLflow Mar 10, 2022
@Kr4is Kr4is changed the title Allow log to an existing run ID in MLflow Allow log to an existing run ID in MLflow with MLFlowLogger Mar 10, 2022
ananthsub
ananthsub reviewed Mar 10, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Kr4is Kr4is requested a review from ananthsub March 11, 2022 17:40
@awaelchli awaelchli mentioned this pull request Mar 12, 2022
Closed
awaelchli
awaelchli reviewed Mar 12, 2022
View reviewed changes
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution. Would you be able to add a test under tests/loggers/test_mlflow.py?

CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/loggers/mlflow.py Outdated Show resolved Hide resolved
@Kr4is Kr4is requested a review from awaelchli March 12, 2022 11:37
@awaelchli
Copy link
Member

@Kr4is we are currently in a feature freeze for the Lightning 1.6 release, which means we only merge bugfix and priority PRs. This feature may have to wait until 1.6 is released and 1.7 development starts.

@awaelchli awaelchli added this to the 1.7 milestone Mar 19, 2022
tchaton
tchaton approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/loggers/mlflow.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 22, 2022
@awaelchli awaelchli enabled auto-merge (squash) March 27, 2022 14:27
@awaelchli awaelchli merged commit e618a33 into Lightning-AI:master Mar 27, 2022
@carmocca carmocca modified the milestones: 1.7, 1.6 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@carmocca carmocca Awaiting requested review from carmocca

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@ananthsub ananthsub Awaiting requested review from ananthsub

Assignees
No one assigned
Labels
logger: mlflow ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Log artifacts to an existing run ID in MLflow
8 participants
@Kr4is @awaelchli @ananthsub @Borda @tchaton @justusschock @rohitgr7 @carmocca