Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optimizer step progress tracking with manual optimization #11848

Merged
merged 6 commits into from Feb 16, 2022
Merged

Support optimizer step progress tracking with manual optimization #11848

merged 6 commits into from Feb 16, 2022

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Feb 10, 2022 •
edited by github-actions bot

What does this PR do?

Adds optimizer step progress tracking support to manual optimization.

Part of #11805

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @awaelchli

@carmocca carmocca added the progress tracking (internal) Related to the progress tracking dataclasses label Feb 10, 2022
@carmocca carmocca added this to the 1.6 milestone Feb 10, 2022
@carmocca carmocca self-assigned this Feb 10, 2022
@carmocca carmocca force-pushed the feat/ptracking-manual-opt-step branch from b543100 to dc28ad0 Compare February 10, 2022 17:18
ethanwharris
ethanwharris approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

pytorch_lightning/loops/optimization/manual_loop.py Show resolved Hide resolved
@carmocca carmocca enabled auto-merge (squash) February 10, 2022 22:33
@carmocca carmocca force-pushed the feat/ptracking-manual-opt-step branch from 5afe552 to 124e9ce Compare February 11, 2022 16:51
@mergify mergify bot added the ready PRs ready to be merged label Feb 14, 2022
@carmocca carmocca merged commit 4cc05b2 into master Feb 16, 2022
@carmocca carmocca deleted the feat/ptracking-manual-opt-step branch February 16, 2022 21:27
rohitgr7 pushed a commit that referenced this pull request Feb 17, 2022
@carmocca @rohitgr7
Support optimizer step progress tracking with manual optimization (#1…
22ea29f 
…1848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees

@carmocca carmocca

Labels
progress tracking (internal) Related to the progress tracking dataclasses ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carmocca @awaelchli @Borda @ethanwharris