Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the output of the optimizer step #11711

Merged
merged 7 commits into from Feb 9, 2022
Merged

Return the output of the optimizer step #11711

merged 7 commits into from Feb 9, 2022

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Feb 3, 2022 •
edited by github-actions bot

What does this PR do?

Fixes #5235

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @rohitgr7

@carmocca carmocca added feature Is an improvement or enhancement optimizer labels Feb 3, 2022
@carmocca carmocca added this to the 1.6 milestone Feb 3, 2022
@carmocca carmocca self-assigned this Feb 3, 2022
rohitgr7
rohitgr7 approved these changes Feb 3, 2022
View reviewed changes
pytorch_lightning/core/lightning.py Show resolved Hide resolved
pytorch_lightning/core/lightning.py Show resolved Hide resolved
pytorch_lightning/lite/wrappers.py Outdated Show resolved Hide resolved
@carmocca @rohitgr7
Update pytorch_lightning/lite/wrappers.py
ac87d99 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@mergify mergify bot added the ready PRs ready to be merged label Feb 4, 2022
@carmocca carmocca enabled auto-merge (squash) February 7, 2022 14:37
tchaton
tchaton approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

tests/core/test_lightning_optimizer.py Show resolved Hide resolved
tests/core/test_lightning_optimizer.py Show resolved Hide resolved
@carmocca carmocca merged commit 8822117 into master Feb 9, 2022
@carmocca carmocca deleted the feat/return-opt-step-output branch February 9, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton tchaton approved these changes

@akihironitta akihironitta akihironitta approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
feature Is an improvement or enhancement optimizer ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Lighting wrapped optimizers do not allow return values
6 participants
@carmocca @ananthsub @awaelchli @tchaton @akihironitta @rohitgr7