Add Bagua Strategy #11146
Merged
Add Bagua Strategy #11146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
wangraying
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
SeanNaren and
tchaton
as code owners
start_training was removed on master
for more information, see https://pre-commit.ci
awaelchli
reviewed
Dec 23, 2021
awaelchli
approved these changes
Jan 24, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
for more information, see https://pre-commit.ci
…g into bagua-plugin
carmocca
approved these changes
Feb 4, 2022
|
🎉 🎉 🎉 🎉 🎉 |
|
Congrats ! Awesome work ! |
ananthsub
reviewed
Feb 4, 2022
| @@ -807,7 +816,7 @@ def select_cluster_environment(self) -> ClusterEnvironment: | |||
| rank_zero_info("Multiprocessing is handled by SLURM.") | |||
| return SLURMEnvironment() | |||
|
|
|||
| for env_type in (TorchElasticEnvironment, KubeflowEnvironment, LSFEnvironment): | |||
| for env_type in (BaguaEnvironment, TorchElasticEnvironment, KubeflowEnvironment, LSFEnvironment): | |||
There was a problem hiding this comment.
why does Bagua need to be the first environment to check?
four4fish
reviewed
Feb 7, 2022
| ) | ||
|
|
||
| @classmethod | ||
| def register_plugins(cls, plugin_registry: Dict) -> None: |
There was a problem hiding this comment.
This method name has to be register_strategies, otherwise won't be called
https://github.com/PyTorchLightning/pytorch-lightning/blob/1203094a201bd38f0b8b77d93bc39fc95f06d8ae/pytorch_lightning/strategies/strategy_registry.py#L137
There is no test covers strategy="bagua", so this issue didn't get caught
I will fix it in #11448, or feel free to open a seperate PR to fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10455
Fixes BaguaSys/bagua#304
Suggested follow ups:
bagua.distributed.runtobagua.distributed.launchto match torchDoes your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃