Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for returning callback from LightningModule.configure_callbacks #11060

Merged
merged 6 commits into from Dec 18, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Dec 14, 2021

What does this PR do?

Fixes: see title

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

part of #1

cc @Borda @carmocca @justusschock @awaelchli @ananthsub @ninginthecloud @jjenniferdai

@rohitgr7 rohitgr7 added feature Is an improvement or enhancement lightningmodule pl.LightningModule labels Dec 14, 2021
@rohitgr7 rohitgr7 added this to the 1.6 milestone Dec 14, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review December 14, 2021 17:19
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@rohitgr7 rohitgr7 enabled auto-merge (squash) December 14, 2021 18:05
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, what motivates this change?

pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
@rohitgr7
Copy link
Contributor Author

out of curiosity, what motivates this change?

not a change but an enhancement. although nothing to be specific. Just for consistency and support w.r.t Trainer(callbacks=...)

@mergify mergify bot added ready PRs ready to be merged has conflicts labels Dec 14, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 merged commit 3461af0 into master Dec 18, 2021
@rohitgr7 rohitgr7 deleted the feat/lm_single_callback branch December 18, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement lightningmodule pl.LightningModule ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants