Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Add support for ReduceLROnPlateau #10860

Merged
merged 4 commits into from Dec 1, 2021
Merged

[CLI] Add support for ReduceLROnPlateau #10860

merged 4 commits into from Dec 1, 2021

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Dec 1, 2021 •
edited by github-actions bot

What does this PR do?

  • Adds support for --lr_scheduler=ReduceLROnPlateau
  • Allows customizing configure_optimizers in the CLI.

Fixes #10850

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @mauvilsa

@carmocca carmocca added feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI labels Dec 1, 2021
@carmocca carmocca added this to the 1.6 milestone Dec 1, 2021
@carmocca carmocca self-assigned this Dec 1, 2021
@carmocca carmocca marked this pull request as ready for review December 1, 2021 04:52
tchaton
tchaton approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

awaelchli
awaelchli approved these changes Dec 1, 2021
View reviewed changes
docs/source/common/lightning_cli.rst Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Dec 1, 2021
@carmocca carmocca enabled auto-merge (squash) December 1, 2021 14:14
@carmocca carmocca merged commit a7aed2a into master Dec 1, 2021
@carmocca carmocca deleted the cli/reduce-lr-on-plateau branch December 1, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Support for ReduceLROnPlateau in CLI
5 participants
@carmocca @awaelchli @tchaton @justusschock @rohitgr7