Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on TypeError during DataLoader reconstruction #10719

Merged
merged 7 commits into from Nov 24, 2021

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Nov 24, 2021

What does this PR do?

Part of #10329

Due to the mechanism we have for injecting the distributed sampler, where the DataLoader is recreated, we have some strong requirements over the __init__ signature arguments. This PR aims to improve the UX when one of these requirements is not met.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @ninginthecloud

@carmocca carmocca added feature Is an improvement or enhancement data handling Generic data-related topic labels Nov 24, 2021
@carmocca carmocca added this to the 1.6 milestone Nov 24, 2021
@carmocca carmocca self-assigned this Nov 24, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca enabled auto-merge (squash) November 24, 2021 02:24
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat !

pytorch_lightning/utilities/data.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/data.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 24, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #10719 (4b9699a) into master (30ec481) will decrease coverage by 4%.
The diff coverage is 89%.

@@           Coverage Diff            @@
##           master   #10719    +/-   ##
========================================
- Coverage      92%      88%    -4%     
========================================
  Files         177      177            
  Lines       16398    16406     +8     
========================================
- Hits        15053    14451   -602     
- Misses       1345     1955   +610     

@carmocca carmocca merged commit f8b2d5b into master Nov 24, 2021
@carmocca carmocca deleted the feat/better-message-on-dataloader-typerror branch November 24, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data handling Generic data-related topic feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants