Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault Tolerant Manual: utilities cleanup #10703

Merged
merged 58 commits into from Nov 24, 2021
Merged

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 23, 2021

What does this PR do?

This PR re-organizes some utilities and remove dead code.

Find the PoC here: #10568

Parts of #10431

To be merged after #10699

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli @ninginthecloud

@tchaton tchaton added this to In progress in Lightning Sprint via automation Nov 23, 2021
@tchaton tchaton added this to the 1.6 milestone Nov 23, 2021
@tchaton tchaton changed the title Fault Tolerant Manual: Cleanup of utilities Fault Tolerant Manual: utilities cleanup Nov 23, 2021
Base automatically changed from add_reloading to master November 23, 2021 17:18
@mergify mergify bot removed the has conflicts label Nov 23, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@mergify mergify bot added the ready PRs ready to be merged label Nov 23, 2021
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Show resolved Hide resolved
pytorch_lightning/utilities/data.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/data.py Outdated Show resolved Hide resolved
@carmocca carmocca merged commit e51a8ee into master Nov 24, 2021
Lightning Sprint automation moved this from In progress to Done Nov 24, 2021
@carmocca carmocca deleted the fault_tolerant_cleanup branch November 24, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fault tolerance feature Is an improvement or enhancement ready PRs ready to be merged
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants