Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added UserWarnings if max_epochs not set in the Trainer class #10700

Merged
merged 36 commits into from Dec 6, 2021
Merged

added UserWarnings if max_epochs not set in the Trainer class #10700

merged 36 commits into from Dec 6, 2021

Conversation

Rajathbharadwaj
Copy link
Contributor

@Rajathbharadwaj Rajathbharadwaj commented Nov 23, 2021 •
edited by awaelchli

What does this PR do?

Intimates user if the max_epochs is not set in the trainer class

Fixes
#10343

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

rohitgr7
rohitgr7 reviewed Nov 24, 2021
View reviewed changes
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
docs/source/common/trainer.rst Outdated Show resolved Hide resolved
@Rajathbharadwaj
Copy link
Contributor Author

I've done the suggested changes @rohitgr7 thanks a ton for helping me out!

Rajathbharadwaj and others added 3 commits November 25, 2021 15:33
@Rajathbharadwaj
changed to rank_zero_warn
31b4d3f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7add35d 
for more information, see https://pre-commit.ci
@Rajathbharadwaj
refactored with utility
36d069c 
cleaned trainer with utility to parse max_epochs and added the utility function in loops/utility
tchaton
tchaton approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
Rajathbharadwaj and others added 2 commits November 26, 2021 19:19
@Rajathbharadwaj
added typing
4421b5a 
added typing to utility function
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8b742f5 
for more information, see https://pre-commit.ci
awaelchli
awaelchli requested changes Nov 27, 2021
View reviewed changes
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for working on this!

docs/source/common/trainer.rst Outdated Show resolved Hide resolved
pytorch_lightning/loops/utilities.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/utilities.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/utilities.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/utilities.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/utilities.py Outdated Show resolved Hide resolved
@Rajathbharadwaj
Copy link
Contributor Author

Hey @tchaton is there anything left to do for this PR?

rohitgr7
rohitgr7 approved these changes Dec 4, 2021
View reviewed changes
pytorch_lightning/loops/utilities.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Dec 4, 2021
@awaelchli awaelchli added the feature Is an improvement or enhancement label Dec 6, 2021
@awaelchli awaelchli added this to the 1.6 milestone Dec 6, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 6, 2021
@tchaton tchaton merged commit 7914e5c into Lightning-AI:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
feature Is an improvement or enhancement ready PRs ready to be merged trainer: argument
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rajathbharadwaj @awaelchli @tchaton @rohitgr7