Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault Tolerant Manual: Add stateful dataloader iter #10674

Merged
merged 41 commits into from Nov 23, 2021
Merged

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 22, 2021

What does this PR do?

Find the complete PoC here: #10568

Parts of #10431

To be merged after

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli @ninginthecloud

@tchaton tchaton self-assigned this Nov 22, 2021
@tchaton tchaton added feature Is an improvement or enhancement fault tolerance labels Nov 22, 2021
@tchaton tchaton added this to the 1.6 milestone Nov 22, 2021
@tchaton tchaton added this to In progress in Lightning Sprint via automation Nov 22, 2021
@mergify mergify bot removed the has conflicts label Nov 22, 2021
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
tests/utilities/test_auto_restart.py Outdated Show resolved Hide resolved
tests/utilities/test_auto_restart.py Outdated Show resolved Hide resolved
Base automatically changed from add_is_obj_stateful to master November 22, 2021 18:48
@mergify mergify bot removed the has conflicts label Nov 22, 2021
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One general and one minor question.

pytorch_lightning/utilities/auto_restart.py Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 23, 2021
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. imo we should offer a mixin class to add state_dict an load_state_dict for samplers/datasets, primarily out of good practice. But this can come at a later date :)

@tchaton tchaton merged commit 1702036 into master Nov 23, 2021
Lightning Sprint automation moved this from In progress to Done Nov 23, 2021
@tchaton tchaton deleted the add_stateful_workers branch November 23, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fault tolerance feature Is an improvement or enhancement ready PRs ready to be merged
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants