Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fault Tolerant Manual: Add _SupportsStateDict to validate a class is stateful #10646

Merged
merged 9 commits into from Nov 22, 2021
Merged

Fault Tolerant Manual: Add _SupportsStateDict to validate a class is stateful #10646

merged 9 commits into from Nov 22, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 19, 2021 •
edited

What does this PR do?

Find the complete PoC here: #10568

Parts of #10431

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @Borda @carmocca @justusschock @awaelchli @ninginthecloud

@tchaton tchaton self-assigned this Nov 19, 2021
@tchaton tchaton added fault tolerance feature Is an improvement or enhancement labels Nov 19, 2021
@tchaton tchaton added this to the 1.6 milestone Nov 19, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

4 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton tchaton enabled auto-merge (squash) November 19, 2021 19:12
@tchaton tchaton mentioned this pull request Nov 22, 2021
Merged
12 tasks
carmocca
carmocca reviewed Nov 22, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 22, 2021
@tchaton tchaton changed the title Fault Tolerant Manual: Add is_obj_stateful utility Fault Tolerant Manual: Add _SupportsStateDict to validate a class is stateful Nov 22, 2021
awaelchli
awaelchli approved these changes Nov 22, 2021
View reviewed changes
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
tests/utilities/test_auto_restart.py Show resolved Hide resolved
@tchaton @awaelchli
Update pytorch_lightning/utilities/auto_restart.py
529c271 
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
@tchaton tchaton merged commit 6acfef6 into master Nov 22, 2021
@tchaton tchaton deleted the add_is_obj_stateful branch November 22, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock justusschock approved these changes

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@ananthsub ananthsub Awaiting requested review from ananthsub

Assignees

@tchaton tchaton

Labels
fault tolerance feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tchaton @ananthsub @awaelchli @Borda @carmocca @justusschock