Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1/n Add FaultTolerantMode #10645

Merged
merged 15 commits into from Nov 22, 2021
Merged

1/n Add FaultTolerantMode #10645

merged 15 commits into from Nov 22, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 19, 2021 •
edited by github-actions bot

What does this PR do?

Find the complete PoC here: #10568

Parts of #10431

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli @ninginthecloud

@tchaton tchaton self-assigned this Nov 19, 2021
@tchaton tchaton added this to the 1.6 milestone Nov 19, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton tchaton added feature Is an improvement or enhancement fault tolerance and removed feature Is an improvement or enhancement labels Nov 19, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton tchaton changed the title 2/n Add FaultTolerantTrainingMode 1/n Add FaultTolerantTrainingMode Nov 19, 2021
ananthsub
ananthsub reviewed Nov 19, 2021
View reviewed changes
pytorch_lightning/utilities/enums.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/enums.py Outdated Show resolved Hide resolved
@tchaton tchaton enabled auto-merge (squash) November 19, 2021 19:12
@mergify mergify bot added the ready PRs ready to be merged label Nov 22, 2021
@carmocca carmocca changed the title 1/n Add FaultTolerantTrainingMode 1/n Add FaultTolerantMode Nov 22, 2021
@tchaton tchaton merged commit 991cd89 into master Nov 22, 2021
@tchaton tchaton deleted the fault_tolerant_enum branch November 22, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub left review comments

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
fault tolerance ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tchaton @ananthsub @carmocca @rohitgr7 @kaushikb11