Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fault Tolerant Manual: Add support for collecting states across processes #10639

Merged
merged 13 commits into from Nov 23, 2021
Merged

Fault Tolerant Manual: Add support for collecting states across processes #10639

merged 13 commits into from Nov 23, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 19, 2021 •
edited

What does this PR do?

This new utility will be used to sync the dataloader states for fault tolerant manual on rank 0 and reload them accordingly on resume. Tested within https://github.com/PyTorchLightning/pytorch-lightning/pull/10623/files with DDP. Works fine :)

Parts of #10431

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli @ninginthecloud

@tchaton tchaton added feature Is an improvement or enhancement fault tolerance labels Nov 19, 2021
@tchaton tchaton added this to the 1.6 milestone Nov 19, 2021
@tchaton tchaton self-assigned this Nov 19, 2021
@tchaton tchaton added this to In progress in Lightning Sprint via automation Nov 19, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

5 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

carmocca
carmocca reviewed Nov 19, 2021
View reviewed changes
tests/utilities/test_distributed.py Outdated Show resolved Hide resolved
tests/utilities/test_distributed.py Outdated Show resolved Hide resolved
tests/utilities/test_distributed.py Show resolved Hide resolved
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
carmocca
carmocca approved these changes Nov 19, 2021
View reviewed changes
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
@tchaton @carmocca
Update pytorch_lightning/utilities/distributed.py
5e0fb6d 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
awaelchli
awaelchli approved these changes Nov 22, 2021
View reviewed changes
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
tests/utilities/test_distributed.py Outdated Show resolved Hide resolved
tests/utilities/test_distributed.py Outdated Show resolved Hide resolved
tests/utilities/test_distributed.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 22, 2021
@tchaton tchaton changed the title 1/n Fault Tolerant Manual: Add support for collecting states across processes Fault Tolerant Manual: Add support for collecting states across processes Nov 23, 2021
ethanwharris
ethanwharris approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@tchaton tchaton enabled auto-merge (squash) November 23, 2021 14:01
@tchaton tchaton merged commit 7cf6374 into master Nov 23, 2021
Lightning Sprint automation moved this from In progress to Done Nov 23, 2021
@tchaton tchaton deleted the collect_states branch November 23, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock left review comments

@four4fish four4fish four4fish left review comments

@awaelchli awaelchli awaelchli approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
fault tolerance feature Is an improvement or enhancement ready PRs ready to be merged
Projects
No open projects
Lightning Sprint
Done
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tchaton @awaelchli @ethanwharris @carmocca @justusschock @four4fish