Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault Tolerant: Add support for fault tolerant dataloader validator #10465

Merged
merged 26 commits into from Nov 26, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 10, 2021

What does this PR do?

Parts of #10431

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@tchaton tchaton self-assigned this Nov 10, 2021
@tchaton tchaton added the feature Is an improvement or enhancement label Nov 10, 2021
@tchaton tchaton added this to the 1.6 milestone Nov 10, 2021
@tchaton tchaton changed the title Add support for fault tolerant dataloader validator 1/n Add support for fault tolerant dataloader validator Nov 10, 2021
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
tests/utilities/test_auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
@tchaton tchaton marked this pull request as draft November 22, 2021 18:48
@tchaton tchaton marked this pull request as ready for review November 24, 2021 18:30
@mergify mergify bot removed the has conflicts label Nov 24, 2021
@tchaton tchaton changed the title 1/n Add support for fault tolerant dataloader validator Fault Tolerant: Add support for fault tolerant dataloader validator Nov 24, 2021
@mergify mergify bot removed the has conflicts label Nov 25, 2021
tests/utilities/test_auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
tests/utilities/test_auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 26, 2021
tests/utilities/test_auto_restart.py Outdated Show resolved Hide resolved
@tchaton tchaton enabled auto-merge (squash) November 26, 2021 19:12
@tchaton tchaton merged commit e94aff1 into master Nov 26, 2021
@tchaton tchaton deleted the fault_tolerant_validator branch November 26, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants