Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

activated color in all pytest runs #4254

Merged
merged 3 commits into from Oct 20, 2020
Merged

activated color in all pytest runs #4254

merged 3 commits into from Oct 20, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 20, 2020

What does this PR do?

This PR adds color to ci/cd to better find errors :)

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@mergify mergify bot requested a review from a team October 20, 2020 12:09
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

This pull request is now in conflict... :(

.drone.yml Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team October 20, 2020 13:16
Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
@ydcjeff ydcjeff added feature Is an improvement or enhancement ci Continuous Integration labels Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #4254 into master will increase coverage by 3%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4254    +/-   ##
=======================================
+ Coverage      90%     93%    +3%     
=======================================
  Files         103     103            
  Lines        7842    7842            
=======================================
+ Hits         7053    7275   +222     
+ Misses        789     567   -222     

Copy link
Contributor

@ydcjeff ydcjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thomas

@mergify mergify bot requested a review from a team October 20, 2020 13:39
@tchaton
Copy link
Contributor Author

tchaton commented Oct 20, 2020

Hey @ydcjeff, yes. I was tired to look for failures and not finding them ahaha 馃憤

@tchaton tchaton added the ready PRs ready to be merged label Oct 20, 2020
@Borda Borda merged commit 829d90b into master Oct 20, 2020
@Borda Borda deleted the ci/add_color branch October 20, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants