fix overwrite & add test for model hooks #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 馃嵒 Comment last updated at 2020-10-20 10:26:52 UTC |
Codecov Report
@@ Coverage Diff @@
## master #4010 +/- ##
=======================================
Coverage 90% 90%
=======================================
Files 103 103
Lines 7863 8228 +365
=======================================
+ Hits 7064 7394 +330
- Misses 799 834 +35 |
Borda
force-pushed
the
tests/model-hooks
branch
from
7b99db3
to
24e0486
Compare
Borda
requested review from
justusschock,
SeanNaren,
SkafteNicki,
teddykoker and
yukw777
Borda
changed the title
Borda
force-pushed
the
tests/model-hooks
branch
from
24e0486
to
80b4ab9
Compare
|
It fixes bug |
|
This pull request is now in conflict... :( |
Borda
force-pushed
the
tests/model-hooks
branch
from
80b4ab9
to
57a8b18
Compare
SeanNaren
approved these changes
Oct 20, 2020
|
@awaelchli lets merge this one and later redo to mocks? |
justusschock
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adding a test for checking ho Model hooks are called, Closes #4001
fixes falling checking the parent model does not have implement hooks such as
'on_validation_start'PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 馃檭