Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup CHANGELOG #12507

Merged
merged 2 commits into from Mar 29, 2022
Merged

Cleanup CHANGELOG #12507

merged 2 commits into from Mar 29, 2022

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Mar 29, 2022 •
edited

What does this PR do?

Removing the whitespace and fixing links

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

@carmocca carmocca added this to the 1.6 milestone Mar 29, 2022
@carmocca carmocca self-assigned this Mar 29, 2022
@carmocca carmocca enabled auto-merge (squash) March 29, 2022 13:15
@mergify mergify bot added the ready PRs ready to be merged label Mar 29, 2022
Borda
Borda approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lest add date of today

@Borda Borda disabled auto-merge March 29, 2022 13:59
@carmocca
Copy link
Member Author

@Borda That was done in #12496

@carmocca carmocca enabled auto-merge (squash) March 29, 2022 14:26
@Borda
Copy link
Member

Borda commented Mar 29, 2022

@Borda That was done in #12496

well, then I still see 2022-MM-DD

@rohitgr7 rohitgr7 disabled auto-merge March 29, 2022 14:34
@carmocca
Copy link
Member Author

It's updated in master. This PR does not reflect it because it has not been rebased.

@carmocca carmocca merged commit 44e3edb into master Mar 29, 2022
@carmocca carmocca deleted the cleanup-changelog branch March 29, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@justusschock justusschock Awaiting requested review from justusschock

Assignees

@carmocca carmocca

Labels
ready PRs ready to be merged release
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carmocca @Borda @ethanwharris @rohitgr7 @kaushikb11