Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning message formatting in save_hyperparameters #12498

Merged
merged 1 commit into from Mar 29, 2022

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Mar 29, 2022

What does this PR do?

Follow up to #12160

The warning message gets rendered like this:

UserWarning: Attribute 'model' is an instance of `nn.Module` and is already saved during checkpointing. 
It is recommended to ignore them using `self.save_hyperparameters(ignore=[model!r])`.

However, it should show:

`self.save_hyperparameters(ignore=['model'])`.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 馃檭

cc @Borda

@awaelchli awaelchli added the bug Something isn't working label Mar 29, 2022
@awaelchli awaelchli added this to the 1.6.x milestone Mar 29, 2022
@awaelchli awaelchli marked this pull request as ready for review March 29, 2022 01:13
@awaelchli awaelchli requested a review from rohitgr7 March 29, 2022 01:13
@mergify mergify bot added the ready PRs ready to be merged label Mar 29, 2022
@awaelchli awaelchli enabled auto-merge (squash) March 29, 2022 02:25
@awaelchli awaelchli merged commit 2de6a9b into master Mar 29, 2022
@awaelchli awaelchli deleted the bugfix/warning-save-model branch March 29, 2022 03:46
@carmocca carmocca modified the milestones: 1.6.x, 1.6 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants