Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI in README.md #12495

Merged
merged 11 commits into from Mar 29, 2022
Merged

Update CI in README.md #12495

merged 11 commits into from Mar 29, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Mar 28, 2022

What does this PR do?

Fixes #12483
Closes #12490
Also a small changelog and minor doc update.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7 @carmocca @akihironitta

@rohitgr7 rohitgr7 added the docs Documentation related label Mar 28, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Mar 28, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review March 28, 2022 17:44
@rohitgr7 rohitgr7 added the ci Continuous Integration label Mar 28, 2022
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 28, 2022
@mergify mergify bot requested a review from a team March 28, 2022 17:58
@rohitgr7 rohitgr7 self-assigned this Mar 28, 2022
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing that we still find typos on the README after 2+ years.

CHANGELOG.md Outdated Show resolved Hide resolved
docs/source/common/trainer.rst Show resolved Hide resolved
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, to be precise, I think we have conda tests with (py3.9, torch1.11) but not with (py3.8, torch1.11).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@carmocca carmocca mentioned this pull request Mar 29, 2022
12 tasks
@rohitgr7 rohitgr7 changed the title Update CI in README.md [wip] Update CI in README.md Mar 29, 2022
rohitgr7 and others added 3 commits March 29, 2022 15:20
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
@rohitgr7 rohitgr7 enabled auto-merge (squash) March 29, 2022 09:57
@rohitgr7 rohitgr7 changed the title [wip] Update CI in README.md Update CI in README.md Mar 29, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, Rohit!

@rohitgr7 rohitgr7 merged commit 71e25f3 into master Mar 29, 2022
@rohitgr7 rohitgr7 deleted the docs/readme_ci branch March 29, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI section in README.md
6 participants