Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to LightningModule.trainer #12345

Merged
merged 13 commits into from Mar 29, 2022

Conversation

johnhenning
Copy link
Contributor

@johnhenning johnhenning commented Mar 16, 2022

What does this PR do?

This is a small change that adds typing to the trainer object within the LightningModule.

Fixes #12337

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@awaelchli awaelchli enabled auto-merge (squash) March 19, 2022 19:41
@awaelchli awaelchli changed the title Trainer Typing Add typing to LightningModule.trainer Mar 19, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 19, 2022
@mergify mergify bot requested a review from a team March 19, 2022 19:42
@mergify mergify bot requested a review from a team March 21, 2022 17:19
Copy link
Member

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ping me when the mypy job is green!

Thank you for your work.

@mergify mergify bot removed the ready PRs ready to be merged label Mar 21, 2022
auto-merge was automatically disabled March 22, 2022 17:40

Head branch was pushed to by a user without write access

@johnhenning
Copy link
Contributor Author

@carmocca Mypy is fixed!

@mergify mergify bot added the ready PRs ready to be merged label Mar 25, 2022
@carmocca carmocca enabled auto-merge (squash) March 25, 2022 16:47
@carmocca carmocca self-assigned this Mar 25, 2022
@carmocca carmocca added this to the 1.6 milestone Mar 25, 2022
@carmocca carmocca merged commit 42169a2 into Lightning-AI:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add typing to the Trainer object within LightningModules
6 participants