Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TPU Availability check from parse devices #12326

Merged
merged 6 commits into from Mar 29, 2022
Merged

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Mar 14, 2022

What does this PR do?

Remove TPU Availability check from parse devices.

Accelerator.parse_devices shouldn't be checking for Accelerator availability, as Accelerator.is_available would be responsible for it.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @Borda @kaushikb11 @rohitgr7 @justusschock @awaelchli

@stale stale bot added the won't fix This will not be worked on label Mar 29, 2022
@Lightning-AI Lightning-AI deleted a comment from stale bot Mar 29, 2022
@stale stale bot removed the won't fix This will not be worked on label Mar 29, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 29, 2022
@kaushikb11 kaushikb11 added this to the 1.6 milestone Mar 29, 2022
@Borda Borda merged commit 041da41 into master Mar 29, 2022
@Borda Borda deleted the refactor/tpu_availablity branch March 29, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants