Ci - drop 37 support #966
Merged
Ci - drop 37 support #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,7 +192,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ 'ubuntu-latest', 'windows-latest', 'macos-latest' ] | |||
| python-version: ['3.7', '3.8', '3.9','3.10', '3.11-dev'] | |||
| python-version: ['3.8', '3.9','3.10', '3.11-dev'] | |||
There was a problem hiding this comment.
Any idea on when we could use plain '3.11' instead of '3.11-dev' ?
There was a problem hiding this comment.
not really - the way i understood this, the "final" version of python needs to be in https://github.com/actions/python-versions/blob/main/versions-manifest.json.
considering 3.11 stable has only been released yesterday, i assume it'll still take a few days - but then changing to "3.11" is absolutely the right approach!
FrancescAlted
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop python 37 wheels
as mentioned in #962 (comment) - there's only really a point in having wheels for 3.8, 3.9, 3.10 and 3.11 (supported versions of python).
Based on this, this PR will aim to
About this last point, only conda-incubator/setup-miniconda is still left - due to the issue linked above (they didn't release an updated new version so far).
The resulting artifact.zip file will contain the following files (notice that 3.6 and 3.7 are now gone).
A "finished" wheels run can be found here - which is the run from the last commit (wheel CI doesn't run on PR's, so you'd not see the result otherwise).