Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FFI definitions for Py_EnterRecursiveCall and Py_LeaveRecursiveCall #2511

Merged
merged 2 commits into from Jul 15, 2022
Merged

Add FFI definitions for Py_EnterRecursiveCall and Py_LeaveRecursiveCall #2511

merged 2 commits into from Jul 15, 2022

Conversation

messense
Copy link
Member

davidhewitt
davidhewitt requested changes Jul 15, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we can support more than just unlimited API - see other comment.

If people think it's worth it, we could potentially also add a safe API along the lines of py.enter_recursive_call(some_cstr, || { /* stuff */ })

pyo3-ffi/src/ceval.rs Outdated Show resolved Hide resolved
@messense @davidhewitt
Update pyo3-ffi/src/ceval.rs
c550683 
Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
davidhewitt
davidhewitt approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Happy to leave the safe API to a separate PR if it's wanted.

@davidhewitt
Copy link
Member

Having some problems with squash on my phone, will try later...

@messense messense merged commit 3c0520d into PyO3:main Jul 15, 2022
@messense messense deleted the ffi-recursion-control branch July 15, 2022 07:45
@messense
Copy link
Member Author

Having some problems with squash on my phone, will try later...

Done.

@davidhewitt davidhewitt mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@messense @davidhewitt