remove ToBorrowedObject trait
#2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejrs
approved these changes
Apr 25, 2022
mejrs
approved these changes
Apr 25, 2022
davidhewitt
force-pushed
the
remove-toborrowedobject
branch
from
132dcd9
to
71f9f18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ToBorrowedObjecttrait hasn't ever been functionally useful with PyO3 on stable Rust, as it relied on thenightlyfeature for specialization.Since we now took the usage of specialization away, there's no point for this trait to exist at all. It's essentially just a wrapper around
ToPyObject, so this PR deprecates the trait and mechanically replaces all PyO3's usage of it withToPyObject.