Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python::register_any #1023

Closed
davidhewitt opened this issue Jul 4, 2020 · 3 comments
Closed

Remove Python::register_any #1023

davidhewitt opened this issue Jul 4, 2020 · 3 comments

Comments

@davidhewitt
Copy link
Member

#1020 is set to remove the last internal use case of register_any. IMO it adds complexity and now doesn't have a clear use case, should we remove this API (or mark deprecated)?

Originally posted by @davidhewitt in https://github.com/PyO3/pyo3/pull/1020/files

Quick github search suggests that @programmerjake is using register_any to allow conversion of &T for a special case:

https://github.com/programmerjake/algebraics/blob/fefb5a60922a6fa1d1dcb7bd0409c5a0a0e66515/src/python.rs#L30

I don't see any other uses on the whole of github 😄

@programmerjake
Copy link
Contributor

feel free to remove it since you're doing a major version bump anyway, I'll be refactoring algebraics's API when I get around to updating it to PyO3 0.11 or later.

@kngwyu
Copy link
Member

kngwyu commented Jul 6, 2020

Thank you for the feedback!

@kngwyu
Copy link
Member

kngwyu commented Jul 9, 2020

Closed via #1020

@kngwyu kngwyu closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants