Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace &'a Ident with Cow in FnArg Enum #4156

Closed
newcomertv opened this issue May 4, 2024 · 0 comments · Fixed by #4157
Closed

Replace &'a Ident with Cow in FnArg Enum #4156

newcomertv opened this issue May 4, 2024 · 0 comments · Fixed by #4157

Comments

@newcomertv
Copy link
Contributor

Deriving PyClass for Tuple Enums requires defining identifiers for anonymous fields.
In PR: #4072 this is done by leaking memory during the build process.

FnArg takes a reference with lifetime which would need to outlive the scope of the derive macro where the ident is created.
In order to deallocate this properly we need to move ownership into FnArg for that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant