Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure fast linker is used by CI jobs #2834

Closed
adamreichold opened this issue Dec 27, 2022 · 2 comments
Closed

Ensure fast linker is used by CI jobs #2834

adamreichold opened this issue Dec 27, 2022 · 2 comments

Comments

@adamreichold
Copy link
Member

adamreichold commented Dec 27, 2022 •
edited

Our CI jobs, especially the ones getting coverage, spent a lot of time building and running doc tests. Since each test is compiled separately, a lot of time is often spent linking those executables and we should make sure our CI jobs use a faster linker, e.g. LLD is often significantly faster and easily enabled by adding -Clink-arg=-fuse-ld=lld to RUSTFLAGS.

Potentially, mold could provide further improvements but I have no personal experience using it.
@davidhewitt davidhewitt mentioned this issue Dec 27, 2022
Closed
@birkenfeld
Copy link
Member

From my recent try, mold worked fine and brought a nice speedup.

@davidhewitt
Copy link
Member

Closing in favour of #4017

@davidhewitt davidhewitt closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: use lld on windows and macos davidhewitt/pyo3
3 participants
@birkenfeld @davidhewitt @adamreichold