Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving coverage #2191

Closed
davidhewitt opened this issue Feb 26, 2022 · 1 comment
Closed

Improving coverage #2191

davidhewitt opened this issue Feb 26, 2022 · 1 comment

Comments

@davidhewitt
Copy link
Member

I believe Rust 1.60 (due in six weeks' time) will contain a stabilised -C instrument-coverage flag to support the coverage for which we currently use nightly.

It might be interesting when that lands to rewrite our CI a bit so that coverage is done as part of all jobs, and we can then remove the separate coverage jobs. That should hopefully help give a truer picture of sections which really are covered however not reflected by the current setup.

Once that change is done, this issue (or another one) can become a general call to action for interested volunteers who'd like to help us bring that coverage number up towards 100% (the ideal, not sure if realistic).

The general steps I'd recommend for anyone who'd be interested in helping achieve that would be to look at the table of files at the bottom of https://app.codecov.io/gh/PyO3/pyo3, identify uncovered sections, and then write PRs adding tests to cover them.

Some issues with coverage that I'm aware of:

@davidhewitt
Copy link
Member Author

Closing in favour of #2453

@davidhewitt davidhewitt closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant