pyo3-macros-backend: support macros inside doc attributes #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
doc-attributes-1.54
branch
7 times, most recently
from
6992060
to
9f95ced
Compare
davidhewitt
changed the title
davidhewitt
force-pushed
the
doc-attributes-1.54
branch
from
9f95ced
to
819b417
Compare
|
I think this is now ready for review if anyone's willing to take a look at it! |
|
(I'll merge this at the weekend if I don't get any comments by then!) |
davidhewitt
force-pushed
the
doc-attributes-1.54
branch
from
819b417
to
f76535f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. (Needs tests, CHANGELOG entry.)In Rust 1.54 it's now valid to write
This PR attempts to support these macros-inside-docs for
pyclassand the other PyO3 macros. It works by collecting all the#[doc]attributes into one bigconcat!macro invocation, forwarding all the inner macros through so thatconcat!can evaluate them all and create the final docstring.