Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplicate dependencies #1337

Closed
5 tasks done
messense opened this issue Dec 6, 2022 · 0 comments · Fixed by #1331
Closed
5 tasks done

Reduce duplicate dependencies #1337

messense opened this issue Dec 6, 2022 · 0 comments · Fixed by #1331
Labels
dependencies Something related to dependencies

Comments

@messense
Copy link
Member

messense commented Dec 6, 2022 •
edited

Currently we have lots of duplicate dependencies, see https://github.com/PyO3/maturin/pull/1336/files, we should reduce them for better compile time.
@messense messense mentioned this issue Dec 13, 2022
Merged
bors bot added a commit that referenced this issue Dec 13, 2022
@bors @messense
Merge #1352
cdc3251 
1352: Run `uniffi-bindgen` command instead of depending on `uniffi_bindgen` crates r=messense a=messense

`uniffi_bindgen` crate is too heavy weight and people uses `uniffi` usually have already installed uniffi-bindgen.

Part of #1337, reduces `--no-default-features` compile time on M2 MacBook Air from 26.2s to 22.3s.

Co-authored-by: messense <messense@icloud.com>
bors bot added a commit that referenced this issue Dec 13, 2022
@bors @messense
Merge #1352
ee02e5b 
1352: Run `uniffi-bindgen` command instead of depending on `uniffi_bindgen` crates r=messense a=messense

`uniffi_bindgen` crate is too heavy weight and people uses `uniffi` usually have already installed uniffi-bindgen.

Part of #1337, reduces `--no-default-features` compile time on M2 MacBook Air from 26.2s to 22.3s.

Co-authored-by: messense <messense@icloud.com>
@messense messense mentioned this issue Dec 28, 2022
Merged
@messense messense mentioned this issue Jan 9, 2023
Merged
@messense messense added the dependencies Something related to dependencies label Jan 9, 2023
@messense messense mentioned this issue Feb 10, 2023
Closed
2 tasks
@messense messense mentioned this issue Feb 22, 2023
Merged
@bors bors bot closed this as completed in e968e8f Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Something related to dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade keyring to 2.0.0 messense/maturin
1 participant
@messense