Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PyMemberDef type of two attributes #395

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

kulikjak
Copy link
Contributor

@kulikjak kulikjak commented Nov 6, 2019

Two members of the main MYSQL structure are incorrectly defined as unsigned integers rather than unsigned longs in a PyMemberDef declaration. This can result in incorrect values being returned (I found this on SPARC, where client_flag attribute was always zero).

For reference, here is the declaration in the MySQL code (same for 5.5, 5.6, 5.7 and 8.0):
https://github.com/mysql/mysql-server/blob/5.7/include/mysql.h#L287

@methane methane closed this Nov 7, 2019
@methane methane reopened this Nov 7, 2019
@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@52d677b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #395   +/-   ##
=========================================
  Coverage          ?   87.16%           
=========================================
  Files             ?       13           
  Lines             ?     1558           
  Branches          ?        0           
=========================================
  Hits              ?     1358           
  Misses            ?      200           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d677b...4432a99. Read the comment docs.

@methane methane merged commit 0da8165 into PyMySQL:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants