Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py38 is now official #393

Merged
merged 2 commits into from
Nov 8, 2019
Merged

py38 is now official #393

merged 2 commits into from
Nov 8, 2019

Conversation

Djailla
Copy link
Contributor

@Djailla Djailla commented Nov 6, 2019

Cleanup travis configuration

@methane methane closed this Nov 7, 2019
@methane methane reopened this Nov 7, 2019
@methane methane changed the title [CI] py38 is now official py38 is now official Nov 7, 2019
@methane methane closed this Nov 7, 2019
@methane methane reopened this Nov 7, 2019
@methane
Copy link
Member

methane commented Nov 7, 2019

Travis doesn't run test for this PR. I don't know why.

@Djailla
Copy link
Contributor Author

Djailla commented Nov 7, 2019

@methane Fixed in #397 I did rebase on this commit too to check travis

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #393 into master will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   87.16%   86.52%   -0.65%     
==========================================
  Files          13       13              
  Lines        1558     1558              
==========================================
- Hits         1358     1348      -10     
- Misses        200      210      +10
Impacted Files Coverage Δ
MySQLdb/compat.py 58.33% <0%> (-41.67%) ⬇️
MySQLdb/__init__.py 80.43% <0%> (-4.35%) ⬇️
MySQLdb/connections.py 80.95% <0%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da8165...393c61a. Read the comment docs.

.travis.yml Outdated
@@ -1,16 +1,15 @@
dist: xenial
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this line.

Bastien Vallet and others added 2 commits November 7, 2019 17:13
@methane methane merged commit 9729f25 into PyMySQL:master Nov 8, 2019
@Djailla Djailla deleted the py38 branch November 8, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants