Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cryptography package makes PyMySQL non-pure Python #697

Closed
KeyWeeUsr opened this issue Jun 28, 2018 · 5 comments · Fixed by #760
Closed

Cryptography package makes PyMySQL non-pure Python #697

KeyWeeUsr opened this issue Jun 28, 2018 · 5 comments · Fixed by #760

Comments

@KeyWeeUsr
Copy link

PyMySQL since 83a8c92 requires cryptography, which requires cffi which requires a compiler thus this package from my POW is not pure Python since. On complete GNU/Linux people might not care, however there are issues with:

  • Alpine Docker images
  • Windows

exactly because of the missing compiler for cffi. Please remove cryptography or make it optional to install (definitely not as a default) or people can just install C/C++ libs if you start requiring a compiler and/or adding C/C++ extensions. :)
@methane
Copy link
Member

methane commented Jun 28, 2018

Cryptography provides wheel files, so you don't need compiler to install it.
https://pypi.org/project/cryptography/#files

@methane
Copy link
Member

methane commented Jun 28, 2018

Would you try rsa based implementation?

@methane
Copy link
Member

methane commented Jun 28, 2018

MySQL requires RSA_PKCS1_OAEP_PADDING but python-rsa doesn't support it yet.
(sybrenstuvel/python-rsa#68)

JocelynDelalande added a commit to JocelynDelalande/ihatemoney that referenced this issue Jul 7, 2018
@JocelynDelalande
Document MySQL setup
9df5a5e 
PyMySQL is more difficult to install since its version 0.9 since it now depends
on *cryptography* lib, which in turns depends on OpenSSL and Python dev files.

See PyMySQL/PyMySQL#697
@JocelynDelalande JocelynDelalande mentioned this issue Jul 7, 2018
Merged
JocelynDelalande added a commit to YunoHost-Apps/ihatemoney_ynh that referenced this issue Jul 7, 2018
@JocelynDelalande
Adapt to PyMysql>=0.9 new requirements
04a8485 
Sadly, this will increase the install time.

Ref spiral-project/ihatemoney#357
Ref PyMySQL/PyMySQL#697
@DDuarte
Copy link

DDuarte commented Jul 10, 2018 •
edited

Had to resort to RUN pip install 'PyMySQL>=0.8.1,<0.9' on Alpine :/

almet pushed a commit to spiral-project/ihatemoney that referenced this issue Jul 16, 2018
@JocelynDelalande @almet
Document MySQL setup (#357)
9caf213 
PyMySQL is more difficult to install since its version 0.9 since it now depends
on *cryptography* lib, which in turns depends on OpenSSL and Python dev files.

See PyMySQL/PyMySQL#697
@miguelgrinberg miguelgrinberg mentioned this issue Sep 24, 2018
Closed
@newlyedward
Copy link

pymysql < 0.9 is ok, however WTForms==2.1 denpends on cffi>1.4.0
according cryptography installing guide
https://cryptography.io/en/latest/installation/
$ sudo apk add gcc musl-dev python3-dev libffi-dev openssl-dev
it works!

cjolowicz added a commit to cjolowicz/microblog that referenced this issue Oct 7, 2018
@cjolowicz
Work around PyMySQL issue #697 (PyMySQL/PyMySQL#697).
7422e1c
This was referenced Nov 28, 2018
Closed
Closed
@methane methane mentioned this issue Dec 18, 2018
Merged
Jojo144 pushed a commit to Jojo144/ihatemoney that referenced this issue Mar 21, 2020
@JocelynDelalande @almet
Document MySQL setup (spiral-project#357)
9d2c103 
PyMySQL is more difficult to install since its version 0.9 since it now depends
on *cryptography* lib, which in turns depends on OpenSSL and Python dev files.

See PyMySQL/PyMySQL#697
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optional cryptography methane/PyMySQL
4 participants
@methane @DDuarte @KeyWeeUsr @newlyedward