Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Security & Analysis To Repository #2960

Merged
merged 1 commit into from
May 28, 2024

Conversation

squatched
Copy link
Contributor

Fixes #2959 by adding a new SecurityAndAnalysis object to Repository. Currently, it simply has some feature flags that are either set to "enabled" or "disabled" so made a SecurityAndAnalysisFeature object and reused it across all the features.

@squatched
Copy link
Contributor Author

I was unable to run sphinx-build doc build as I got the following error:

$ sphinx-build doc build
Running Sphinx v2.4.5

Sphinx version error:
The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.

@jackylamhk
Copy link

I was unable to run sphinx-build doc build as I got the following error:

$ sphinx-build doc build
Running Sphinx v2.4.5

Sphinx version error:
The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.

Try running it on Python 3.8. See

basepython = python3.8

Though I believe the CI workflow will take care of building the documentation for you.

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi changed the title Fixes #2959: Adds Security & Analysis To Repository Adds Security & Analysis To Repository May 20, 2024
@EnricoMi EnricoMi added this pull request to the merge queue May 28, 2024
Merged via the queue into PyGithub:main with commit f22af54 May 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Org Repositories Missing security_and_analysis Member
3 participants