From ed7d0fe94f063d228a7dd95b7df5ae1bedb0707a Mon Sep 17 00:00:00 2001 From: Sachi King Date: Wed, 2 Jun 2021 14:59:42 +1000 Subject: [PATCH] Add type to OrderedDict (#1954) OrderedDict needs to be typed just like Dict needs to be typed. The OrderedDict "input" variable key and value are used to append to a string without any processing, so it seems unlikely that something other than a string would be valid. --- github/Requester.pyi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/github/Requester.pyi b/github/Requester.pyi index 6070c4fd82..574b1517c4 100644 --- a/github/Requester.pyi +++ b/github/Requester.pyi @@ -158,7 +158,7 @@ class Requester: url: str, parameters: Optional[Dict[str, Any]] = ..., headers: Optional[Dict[str, Any]] = ..., - input: Optional[OrderedDict] = ..., + input: Optional[OrderedDict[str, str]] = ..., cnx: Optional[ Union[HTTPRequestsConnectionClass, HTTPSRequestsConnectionClass] ] = ..., @@ -169,7 +169,7 @@ class Requester: url: str, parameters: Optional[Dict[str, Any]] = ..., headers: Optional[Dict[str, Any]] = ..., - input: Optional[OrderedDict] = ..., + input: Optional[OrderedDict[str, str]] = ..., ) -> Tuple[Dict[str, Any], Optional[Dict[str, Any]]]: ... @classmethod def resetConnectionClasses(cls) -> None: ...