[Backport maintenance/2.16.x] [spelling] Ignore spelling in type/mypy type ignore comments #8373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
enchant does not understand class name well enough so it creates false positives, and mypy type ignore comments with additional text are a syntax error anyway, so raising a spelling mistakes for it is not really important. (cherry picked from commit b5aab35)
Pierre-Sassoulas
added
the
False Positive 🦟
Pierre-Sassoulas
approved these changes
Mar 2, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## maintenance/2.16.x #8373 +/- ##
======================================================
- Coverage 95.53% 95.53% -0.01%
======================================================
Files 177 177
Lines 18646 18642 -4
======================================================
- Hits 17814 17810 -4
Misses 832 832
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b5aab35 from #8370.