Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crash] Fix crashes on python interpreter < 3.9 #8163

Merged
merged 1 commit into from Feb 2, 2023

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #8161 @MarcSchmitzer we can add you as co-author if you want (need your commit email) :)

@Pierre-Sassoulas Pierre-Sassoulas added the Crash πŸ’₯ A bug that makes pylint crash label Feb 2, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.16.1 milestone Feb 2, 2023
@mschmitzer
Copy link
Contributor

@MarcSchmitzer we can add you as co-author if you want (need your commit email) :)

That would be cool. Commit email would be marc@solute.de

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #8163 (61f4f1e) into main (5c0084b) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8163   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         177      177           
  Lines       18622    18622           
=======================================
  Hits        17791    17791           
  Misses        831      831           
Impacted Files Coverage Ξ”
pylint/checkers/imports.py 94.28% <0.00%> (ΓΈ)

Closes pylint-dev#8161

Co-authored-by: Marc Schmitzer <marc@solute.de>
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) February 2, 2023 08:58
@Pierre-Sassoulas
Copy link
Member Author

Thank you for your help and congratulations on becoming a pylint contributor @MarcSchmitzer !

@Pierre-Sassoulas
Copy link
Member Author

This part was not tested, it explains the crash. Should we blindly fix it or do you have a possible test in mind @DanielNoord ?

@DanielNoord
Copy link
Collaborator

Let's blindly fix. Can't be worse than current situation. I know this was pretty poorly tested code in general and the original fix is only because I made the typing stricter, which was already an improvement over previous state.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 61f4f1e

@Pierre-Sassoulas Pierre-Sassoulas merged commit 4689b19 into pylint-dev:main Feb 2, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the hotfix-8161 branch February 2, 2023 09:33
github-actions bot pushed a commit that referenced this pull request Feb 2, 2023
Closes #8161

Co-authored-by: Marc Schmitzer <marc@solute.de>
(cherry picked from commit 4689b19)
Pierre-Sassoulas added a commit that referenced this pull request Feb 2, 2023
Closes #8161

Co-authored-by: Marc Schmitzer <marc@solute.de>
(cherry picked from commit 4689b19)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported Crash πŸ’₯ A bug that makes pylint crash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pylint 2.16 fails on python 3.8.16
3 participants