Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print this error to stderr instead of stdout. #8142

Merged
merged 1 commit into from Jan 31, 2023

Conversation

yilei
Copy link
Contributor

@yilei yilei commented Jan 31, 2023

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ“œ Docs

Description

Print this error to stderr instead of stdout, otherwise it produces invalid formatted outputs.

This is similar to #6597, please let me know if you want me to file a separate issue.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #8142 (8362c57) into main (c668dca) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8142   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         177      177           
  Lines       18622    18622           
=======================================
  Hits        17791    17791           
  Misses        831      831           
Impacted Files Coverage Ξ”
pylint/lint/utils.py 96.00% <ΓΈ> (ΓΈ)

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! How did you encounter the issue ? (I.e. there's a crash in the wild ?)

@Pierre-Sassoulas Pierre-Sassoulas added Skip news πŸ”‡ This change does not require a changelog entry Maintenance Discussion or action around maintaining pylint or the dev workflow labels Jan 31, 2023
@Pierre-Sassoulas Pierre-Sassoulas merged commit fb977e1 into pylint-dev:main Jan 31, 2023
@yilei yilei deleted the stdout branch January 31, 2023 06:54
@yilei
Copy link
Contributor Author

yilei commented Jan 31, 2023

Same as #6597. We have our internal tool that's built on top of pylint, and it uses the stdout for structured lint error outputs (equivalent of --output-format=json).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news πŸ”‡ This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants