Fix issues with new typing Union syntax (Py310)

[cdce8p]

Description

Add regression tests for new typing Union syntax.
Bump astroid to 2.13.4.

Requires pylint-dev/astroid#1977
Closes #8119

[Pierre-Sassoulas]

It seems there's been a core dump two times in a row in the 3.7 tests and once in the 3.8 tests ? I wonder if this what happen in case of timeout now or if this is a genuine problem with astroid 2.14 ?

[cdce8p]

It seems there's been a core dump two times in a row in the 3.7 tests and once in the 3.8 tests ? I wonder if this what happen in case of timeout now or if this is a genuine problem with astroid 2.14 ?

It's the recursion issue from pylint-dev/astroid#1982 again, sadly. I wouldn't consider astroid broken though so we don't need to yank the releases. However, it might make sense to revert the change. What do you think?

It's a bit of work, but I could do it. With that I would also consider releasing 2.13.5 and 2.14.1.

[Pierre-Sassoulas]

Hmm yeah, I have no idea how to fix this. Maybe a partial revert keeping the new added tests ? Also we don't need to maintain 2.13 anymore, we could only release 2.14.1.

[cdce8p]

Also we don't need to maintain 2.13 anymore, we could only release 2.14.1.

Yeah, also I kind of broke the last release of 2.13. Would be nice to fix it even if we don't "need" to.
I can try to do the backports manually, it should probably work then.

[Pierre-Sassoulas]

Right, it branched 3 days ago, it's reasonable, there's not going to be any conflicts.

[cdce8p]

Did the revert, released both 2.13.5 + 2.14.1, and merged everything back into main. This should work now 🤞🏻

[codecov]

Codecov Report

Merging #8122 (c70285d) into main (c70285d) will not change coverage.
The diff coverage is n/a.

❗ Current head c70285d differs from pull request most recent head 3f3fc1b. Consider uploading reports for the commit 3f3fc1b to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8122   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         177      177           
  Lines       18622    18622           
=======================================
  Hits        17791    17791           
  Misses        831      831           

[Pierre-Sassoulas]

Great work with all the release ! I suppose it prove it's easier to do now than before 😄

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on black:
The following messages are no longer emitted:

1. no-member:
   Instance of 'SyncManager' has no 'Lock' member; maybe 'RLock'?
   https://github.com/psf/black/blob/226cbf0226ee3bc26972357ba54c36409e9a84ae/src/black/concurrency.py#L151

This comment was generated for commit 3f3fc1b