Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug when loading user-provided msg-template. #7976

Merged
merged 5 commits into from
Dec 27, 2022

Conversation

clavedeluna
Copy link
Collaborator

@clavedeluna clavedeluna commented Dec 23, 2022

Type of Changes

Type
βœ“ πŸ› Bug fix

Closes #5636

@coveralls
Copy link

coveralls commented Dec 23, 2022

Pull Request Test Coverage Report for Build 3787236917

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 101 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.002%) to 95.447%

Files with Coverage Reduction New Missed Lines %
pylint/extensions/private_import.py 1 99.17%
pylint/extensions/consider_ternary_expression.py 3 88.0%
pylint/pyreverse/diagrams.py 4 91.95%
pylint/checkers/base/basic_error_checker.py 5 95.56%
pylint/checkers/refactoring/recommendation_checker.py 5 96.35%
pylint/epylint.py 6 84.13%
pylint/checkers/utils.py 7 95.31%
pylint/checkers/base_checker.py 8 89.55%
pylint/checkers/refactoring/refactoring_checker.py 15 98.13%
pylint/checkers/variables.py 23 97.38%
Totals Coverage Status
Change from base Build 3752298849: 0.002%
Covered Lines: 17672
Relevant Lines: 18515

πŸ’› - Coveralls

@github-actions

This comment has been minimized.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@DanielNoord
Copy link
Collaborator

@clavedeluna Could you make the news message a little more descriptive? This doesn't really help anybody looking at the changelog to see what has changed. Fix itself LGTM!

@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 5f2fdd6

@DanielNoord
Copy link
Collaborator

@clavedeluna Could you fix the pre-commit failure?

@Pierre-Sassoulas Pierre-Sassoulas merged commit 03bd452 into pylint-dev:main Dec 27, 2022
@github-actions
Copy link
Contributor

The backport to maintenance/2.15.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-7976-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03bd452620558a2159715ce7f5aad9071910e1a4
# Push it to GitHub
git push --set-upstream origin backport-7976-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x

Then, create a pull request where the base branch is maintenance/2.15.x and the compare/head branch is backport-7976-to-maintenance/2.15.x.

Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this pull request Dec 27, 2022
Closes pylint-dev#5636

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pierre-Sassoulas added a commit that referenced this pull request Dec 27, 2022
Closes #5636

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Co-authored-by: Dani Alcala <112832187+clavedeluna@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using custom braces in message template does not work
4 participants