-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use-sequence-for-iteration
when unpacking a set with *
#7975
Conversation
This comment has been minimized.
This comment has been minimized.
90d4cdf
to
1995a49
Compare
Pull Request Test Coverage Report for Build 3781183585
π - Coveralls |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
use-sequence-for-iteration
when unpacking a set with *
use-sequence-for-iteration
when unpacking a set with *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Would you mind doing a recursive search? We should have some utils for this.
This fails β¬οΈ
def deduplicate_nested_sets(input1, input2, input3, input4):
for thing in {{*input1, *input2}, {*input3, *input4}}:
print(thing)
for more information, see https://pre-commit.ci
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit d634048 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ππ»
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-7975-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cf5ea8a32bcdac0bd889f973272c59599b40af95
# Push it to GitHub
git push --set-upstream origin backport-7975-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x Then, create a pull request where the |
#7988) Co-authored-by: Dani Alcala <112832187+clavedeluna@users.noreply.github.com>
Type of Changes
Description
Closes #5788