Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump dill to >= 0.3.6, prevents tests hanging with python3.11 #7918

Merged
merged 4 commits into from Dec 14, 2022

Conversation

sandrotosi
Copy link
Contributor

@sandrotosi sandrotosi commented Dec 10, 2022

Fixes #7916

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sandrotosi ! The fix I did is based on https://github.com/PyCQA/pylint/pull/7838/files#r1031123153. Look like dill did not handle metadata correctly and we do need to be precise if we want to support 3.7 to 3.11.

pyproject.toml Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.9 milestone Dec 11, 2022
@Pierre-Sassoulas Pierre-Sassoulas added Skip news 🔇 This change does not require a changelog entry backport maintenance/2.15.x labels Dec 11, 2022
@coveralls
Copy link

coveralls commented Dec 11, 2022

Pull Request Test Coverage Report for Build 3686020157

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.474%

Totals Coverage Status
Change from base Build 3682617693: 0.0%
Covered Lines: 17657
Relevant Lines: 18494

💛 - Coveralls

@Pierre-Sassoulas
Copy link
Member

Seems like forcing the CI environment to be cache invalidated made a pre-existing issue appear for pypy 3.8 (brought by #7863 ?). I'll check that later on.

@github-actions

This comment has been minimized.

DanielNoord
DanielNoord previously approved these changes Dec 11, 2022
@Pierre-Sassoulas Pierre-Sassoulas dismissed stale reviews from DanielNoord and themself via f5f8c4c December 13, 2022 13:49
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit f5f8c4c

@Pierre-Sassoulas
Copy link
Member

Merging because the pypy 3.8 problem exists on main anyway.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 5a93635 into pylint-dev:main Dec 14, 2022
@github-actions
Copy link
Contributor

The backport to maintenance/2.15.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-7918-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a93635a4a220b16b83b859c2c7f4421ce8d05cd
# Push it to GitHub
git push --set-upstream origin backport-7918-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x

Then, create a pull request where the base branch is maintenance/2.15.x and the compare/head branch is backport-7918-to-maintenance/2.15.x.

Pierre-Sassoulas added a commit that referenced this pull request Dec 14, 2022
…7918)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@Pierre-Sassoulas
Copy link
Member

Backported in 83668de

@DanielNoord
Copy link
Collaborator

@Pierre-Sassoulas Do we know why main is broken?

@Pierre-Sassoulas
Copy link
Member

No idea, the error (only on pypy 3.8) is very strange and seem related to #7863 (?)

@DanielNoord
Copy link
Collaborator

Should we revert that commit then?

@Pierre-Sassoulas
Copy link
Member

It's just an intuition based on the test fail message (so : maybe 😄 ). TBH I don't have a lot of respect for pypy as I never used it myself so just excluding the interpreter in conf would not bother me.

@GideonBear
Copy link
Contributor

Second time my PR causes failures on just PyPy 3.8 😭

@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Dec 15, 2022

The bug is really strange btw:

import dataclasses
from dataclasses import dataclass

@dataclass
class CustomDataClass: #  multiple-statements ??!
    my_var: list[int]

@dataclasses.dataclass
class CustomDataClass2: #  multiple-statements ??!
    my_var: list[int]

@dataclass()
class CustomDataClass3: #  multiple-statements ??!
    my_var: list[int]

@GideonBear
Copy link
Contributor

@Pierre-Sassoulas
Should the discussion about this failure happen in a separate issue?
I reproduced it on my local machine, I'm now trying to debug it.

@Pierre-Sassoulas
Copy link
Member

See #7945 for a hot fix, if we have a real fix then we can apply it instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pylint/2.15.8: python/3.11.1: debian: tests/test_check_parallel.py tests fail/hang indefinitely
6 participants