Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport maintenance/2.15.x] Define Protocol as abstract to prevent abstract-method FP #7879

Merged
merged 1 commit into from Dec 5, 2022
Merged

[Backport maintenance/2.15.x] Define Protocol as abstract to prevent abstract-method FP #7879

merged 1 commit into from Dec 5, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport 85e7d93 from #7839.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.8 milestone Nov 30, 2022
@Pierre-Sassoulas Pierre-Sassoulas added Blocked 🚧 Blocked by a particular issue Maintenance Discussion or action around maintaining pylint or the dev workflow labels Nov 30, 2022
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the backport-7839-to-maintenance/2.15.x branch from c657bdb to 24fd5ae Compare December 4, 2022 15:40
@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label Dec 4, 2022
@Pierre-Sassoulas
Copy link
Member

@clavedeluna do you think we can fix this easily in 2.15.8 or should we wait for 2.16.0 ?

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.15.8, 2.15.9 Dec 4, 2022
@clavedeluna
Copy link
Collaborator

I guess I Don't have perms to push directly here so to fix this all you have to do is run
python tests/test_functional.py --update-functional-output -k "test_functional[protocol_classes_abstract]"

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.15.9, 2.15.8 Dec 5, 2022
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the backport-7839-to-maintenance/2.15.x branch from 24fd5ae to bb96989 Compare December 5, 2022 12:04
@Pierre-Sassoulas
Copy link
Member

Duh, of course.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3619833922

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 95.349%
Totals Coverage Status
Change from base Build 3614027596: 0.01%
Covered Lines: 17098
Relevant Lines: 17932
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit 6178e41 into maintenance/2.15.x Dec 5, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-7839-to-maintenance/2.15.x branch December 5, 2022 12:18
@Swhistler1
Copy link

Backport 85e7d93 from #7839.

  • MOE

@Pierre-Sassoulas
Copy link
Member

@Swhistler1 what does MOE mean ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.15.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pierre-Sassoulas @clavedeluna @coveralls @Swhistler1