Do not crash if next() is called without arguments
#7831
Merged
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3543376537
💛 - Coveralls |
Pierre-Sassoulas
added
Crash 💥
Pierre-Sassoulas
previously approved these changes
Nov 23, 2022
| @@ -1135,6 +1135,10 @@ def _looks_like_infinite_iterator(param: nodes.NodeNG) -> bool: | |||
| # A next() method, which is now what we want. | |||
| return | |||
|
|
|||
| if len(node.args) == 0: | |||
| # builtin next method should never be called without args. | |||
There was a problem hiding this comment.
Suggested change
| # builtin next method should never be called without args. | |
| # handle cases where builtin.next was called with args. | |
| # see https://github.com/PyCQA/pylint/issues/7828 |
There was a problem hiding this comment.
Maybe "handle cases where builtin.next was called withOUT args."?
doc/whatsnew/fragments/7828.bugfix
Outdated
| @@ -0,0 +1,3 @@ | |||
| Fixes a crash during ``stop-iteration-return`` if builtin ``next`` is called without arguments. | |||
There was a problem hiding this comment.
Suggested change
| Fixes a crash during ``stop-iteration-return`` if builtin ``next`` is called without arguments. | |
| Fixes a crash in ``stop-iteration-return`` when the ``next`` builtin is called without arguments. |
opened #7832 to see who can pick it up. I may be able to later today but it's pressing so first comes first gets! |
This comment has been minimized.
This comment has been minimized.
clavedeluna
force-pushed
the
7828-next-crash
branch
from
7f373b9 to
ace4c1d
Compare
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
previously approved these changes
Nov 23, 2022
|
Blocked by #7826 |
clavedeluna
force-pushed
the
7828-next-crash
branch
from
ace4c1d to
fc146c7
Compare
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit fc146c7 |
Pierre-Sassoulas
changed the title
next() is called without arguments
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> (cherry picked from commit a9c1cda)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Nov 24, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> (cherry picked from commit a9c1cda)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Pylint should not crash if
next()is called, even tho that's incorrect python!Closes #7828