Add `content: write` rights for backporting job #7826

Pierre-Sassoulas · 2022-11-23T09:14:20Z

Type of Changes

	Type
✓	🐛 Bug fix

Description

We need it to push to the backporting branch after cherry-picking. See https://github.com/PyCQA/pylint/pull/7810\#issuecomment-1324742960

Also include change we did on the maintenance branch to not run primers.

Refs #7804, #7815 #7810

coveralls · 2022-11-23T09:39:06Z

Pull Request Test Coverage Report for Build 3542250303

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.427%

Totals
Change from base Build 3534208420:	0.0%
Covered Lines:	17550
Relevant Lines:	18391

💛 - Coveralls

DanielNoord

Primer changes look good!

cdce8p

Could you add a version comment here?
https://github.com/PyCQA/pylint/blob/f7d681b5a79e5781ab8072fe64459b199955a1f6/.github/workflows/backport.yml#L26

Similar to the one here. Dependabot will auto-update that too.
https://github.com/PyCQA/pylint/blob/f7d681b5a79e5781ab8072fe64459b199955a1f6/.github/workflows/primer_comment.yaml#L134

cdce8p · 2022-11-24T16:04:48Z

.github/workflows/backport.yml

@@ -7,6 +7,7 @@ on:

 permissions:
  pull-requests: write
+  content: write


It was worth a shot at least.

We need it to push to the backporting branch after cherry-picking See pylint-dev#7810

.github/workflows/backport.yml

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>

cdce8p

Permissions look fine. Haven't followed the discussion around primer runs though.
If it should only run on main, I guess it's also good.

github-actions · 2022-11-24T17:00:21Z

🤖 Effect of this PR on checked open source code: 🤖

Effect on django:
The following messages are no longer emitted:

redefined-variable-type:
Redefinition of value type from django.db.models.expressions.Value to django.db.models.expressions.BaseExpression
https://github.com/django/django/blob/d526d1569ca4a1e62bb6a1dd779d2068766d348c/django/db/models/lookups.py#L60

Effect on music21:
The following messages are now emitted:

redefined-variable-type:
Redefinition of theRest type from music21.note.Rest to list
https://github.com/cuthbertLab/music21/blob/b274aa58d44b89484273071703d17dc2450016eb/music21/mei/base.py#L2310
redefined-variable-type:
Redefinition of theSpace type from music21.note.Rest to list
https://github.com/cuthbertLab/music21/blob/b274aa58d44b89484273071703d17dc2450016eb/music21/mei/base.py#L2358

Effect on pandas:
The following messages are now emitted:

redefined-variable-type:
Redefinition of result type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.multi.MultiIndex
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/indexes/multi/test_reshape.py#L126
no-member:
Instance of 'PeriodIndex' has no 'tz' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/indexes/datetimes/methods/test_shift.py#L101
redefined-variable-type:
Redefinition of expected type from tuple to pandas.core.series.Series
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/series/methods/test_astype.py#L499
invalid-unary-operand-type:
bad operand type for unary ~: IntervalArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_ops.py#L9
redefined-variable-type:
Redefinition of expected type from pandas.core.series.Series to pandas.core.frame.DataFrame
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_ops.py#L17
redefined-variable-type:
Redefinition of expected type from pandas.core.series.Series to pandas.core.arrays.period.PeriodArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_function.py#L28
redefined-variable-type:
Redefinition of other type from .ndarray to pandas.core.series.Series
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_comparison.py#L34
invalid-unary-operand-type:
bad operand type for unary -: IntervalArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_arithmetic.py#L213
invalid-unary-operand-type:
bad operand type for unary +: IntervalArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_arithmetic.py#L213
invalid-unary-operand-type:
bad operand type for unary -: IntervalArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/integer/test_arithmetic.py#L324
invalid-unary-operand-type:
bad operand type for unary +: IntervalArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/integer/test_arithmetic.py#L324
redefined-variable-type:
Redefinition of indexer type from pandas.core.indexes.numeric.Int64Index to pandas.core.indexes.datetimes.DatetimeIndex
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/algorithms.py#L1360
redefined-variable-type:
Redefinition of data type from pandas.core.internals.array_manager.SingleArrayManager to pandas.core.internals.managers.BlockManager
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/series.py#L377
unsupported-assignment-operation:
'mangled_aggspec' does not support item assignment
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/apply.py#L1448
redefined-variable-type:
Redefinition of mangled_aggspec type from str to list
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/apply.py#L1450
redefined-variable-type:
Redefinition of indexer type from slice to list
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/frame.py#L3816
no-member:
Instance of 'RangeIndex' has no 'levels' member; maybe 'nlevels'?
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/indexes/base.py#L2040
no-member:
Instance of 'RangeIndex' has no 'codes' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/indexes/base.py#L2041
redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.indexes.base.Index
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/_testing/__init__.py#L277

The following messages are no longer emitted:

redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.numpy_.PandasArray to pandas.core.indexes.base.Index
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/_testing/__init__.py#L277
redefined-variable-type:
Redefinition of indexer type from list to .ndarray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/frame.py#L3820
redefined-variable-type:
Redefinition of data type from pandas.core.internals.array_manager.SingleArrayManager to pandas.core.internals.managers.SingleBlockManager
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/series.py#L377
redefined-variable-type:
Redefinition of index type from pandas.core.indexes.base.Index to pandas.core.indexes.range.RangeIndex
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/series.py#L449
redefined-variable-type:
Redefinition of other type from pandas.core.arrays.period.PeriodArray to pandas.core.arrays.interval.IntervalArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/arrays/interval.py#L739
no-member:
Instance of 'Index' has no 'levels' member; maybe 'nlevels'?
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/indexes/base.py#L2040
no-member:
Instance of 'Index' has no 'codes' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/indexes/base.py#L2041
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L547
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L548
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L549
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L556
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L557
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L558
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L559
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L561
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L562
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L564
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L566
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L603
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L604
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L605
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L606
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L607
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L616
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L617
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L618
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L619
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L620
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L621
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L622
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L623
no-member:
Instance of 'SingleBlockManager' has no 'iget' member
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L624
redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.arrays.floating.FloatingArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/integer/test_arithmetic.py#L117
redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/integer/test_function.py#L20
redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.arrays.floating.FloatingArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_arithmetic.py#L68
redefined-variable-type:
Redefinition of res type from pandas.core.arrays.period.PeriodArray to pandas.core.arrays.floating.FloatingArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_construction.py#L142
redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_function.py#L21
redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_function.py#L36
redefined-variable-type:
Redefinition of other type from pandas.core.arrays.period.PeriodArray to .ndarray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_comparison.py#L32
redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_ops.py#L11
redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_function.py#L21
redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_function.py#L64
redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_function.py#L125
redefined-variable-type:
Redefinition of expected type from .ndarray to pandas.core.arrays.period.PeriodArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/string_/test_string.py#L211
redefined-variable-type:
Redefinition of expected type from .ndarray to pandas.core.arrays.period.PeriodArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/string_/test_string.py#L252
redefined-variable-type:
Redefinition of expected type from list to pandas.core.arrays.period.PeriodArray
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arithmetic/test_datetime64.py#L239
redefined-variable-type:
Redefinition of result type from pandas.core.indexes.numeric.Int64Index to pandas.core.indexes.multi.MultiIndex
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/indexes/multi/test_reshape.py#L126
redefined-variable-type:
Redefinition of dti type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.numeric.Int64Index
https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/indexes/datetimes/test_misc.py#L254

This comment was generated for commit 41cd785

* Do not run primers tests on backporting branches * Add content: write rights for backporting job We need it to push to the backporting branch after cherry-picking See #7810 * [github actions] Add a version comment so the tag is clearer Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>

Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Nov 23, 2022

Pierre-Sassoulas requested review from DanielNoord and cdce8p November 23, 2022 09:14

Pierre-Sassoulas added this to the 2.15.7 milestone Nov 23, 2022

Pierre-Sassoulas added the backport maintenance/2.15.x label Nov 23, 2022

This comment has been minimized.

Sign in to view

This was referenced Nov 23, 2022

Do not crash if next() is called without arguments #7831

Merged

Fix crash when using enumerate with start and a class attribute #7824

Merged

Pierre-Sassoulas force-pushed the last-fix-to-backporting-action branch from db8edc8 to a67d0cf Compare November 23, 2022 17:09

This comment has been minimized.

Sign in to view

DanielNoord previously approved these changes Nov 23, 2022

View reviewed changes

Pierre-Sassoulas mentioned this pull request Nov 23, 2022

Manual backporting for 2.15.7 release #7837

Merged

clavedeluna previously approved these changes Nov 24, 2022

View reviewed changes

cdce8p reviewed Nov 24, 2022

View reviewed changes

Pierre-Sassoulas added 2 commits November 24, 2022 17:15

Do not run primers tests on backporting branches

8c22930

Add content: write rights for backporting job

ce899e8

We need it to push to the backporting branch after cherry-picking See pylint-dev#7810

Pierre-Sassoulas dismissed stale reviews from clavedeluna and DanielNoord via c4afd5d November 24, 2022 16:17

Pierre-Sassoulas force-pushed the last-fix-to-backporting-action branch from a67d0cf to c4afd5d Compare November 24, 2022 16:17

Pierre-Sassoulas requested a review from cdce8p November 24, 2022 16:17

cdce8p reviewed Nov 24, 2022

View reviewed changes

.github/workflows/backport.yml Outdated Show resolved Hide resolved

[github actions] Add a version comment so the tag is clearer

41cd785

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>

Pierre-Sassoulas force-pushed the last-fix-to-backporting-action branch from e858bd1 to 41cd785 Compare November 24, 2022 16:21

Pierre-Sassoulas requested a review from cdce8p November 24, 2022 16:22

cdce8p approved these changes Nov 24, 2022

View reviewed changes

Pierre-Sassoulas merged commit 87fedef into pylint-dev:main Nov 24, 2022

Pierre-Sassoulas deleted the last-fix-to-backporting-action branch November 24, 2022 18:52

Pierre-Sassoulas added Backported and removed backport maintenance/2.15.x labels Feb 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `content: write` rights for backporting job #7826

Add `content: write` rights for backporting job #7826

Pierre-Sassoulas commented Nov 23, 2022

coveralls commented Nov 23, 2022 •

edited

This comment has been minimized.

This comment has been minimized.

DanielNoord left a comment

cdce8p left a comment

cdce8p Nov 24, 2022

cdce8p left a comment

github-actions bot commented Nov 24, 2022

Add content: write rights for backporting job #7826

Add content: write rights for backporting job #7826

Conversation

Pierre-Sassoulas commented Nov 23, 2022

Type of Changes

Description

coveralls commented Nov 23, 2022 • edited

Pull Request Test Coverage Report for Build 3542250303

💛 - Coveralls

This comment has been minimized.

This comment has been minimized.

DanielNoord left a comment

Choose a reason for hiding this comment

cdce8p left a comment

Choose a reason for hiding this comment

cdce8p Nov 24, 2022

Choose a reason for hiding this comment

cdce8p left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 24, 2022

Add `content: write` rights for backporting job #7826

Add `content: write` rights for backporting job #7826

coveralls commented Nov 23, 2022 •

edited