Use relative paths in create_contributor_list.py
#7656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
added
Needs backport
Pull Request Test Coverage Report for Build 3296438008
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Thank you ! This is part of #7362 please do not hesitate to edit the description or comment on it :)
10 tasks
cdce8p
added a commit
to cdce8p/pylint
that referenced
this pull request
Oct 21, 2022
cdce8p
added
Backported
and removed
Needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On MacOS
Path(__file__).parent.parentseems to be resolved to an absolute path. This causes thecontibutors-txtscript to insert a duplicate header as the path for.contributors_aliases.jsondoesn't match anymore.Noticed this while testing the release workflow.
https://github.com/PyCQA/pylint/blob/15dd079792ce8e6b37856450f9e4a928f11b3549/CONTRIBUTORS.txt#L1-L5
Refs: #7362