Fix unhashable-member crash when lambda used as a dict key
#7454
Conversation
jacobtylerwalls
added
Needs backport
jacobtylerwalls
changed the title
unhashable-member crash when lambda used as a dict keyunhashable-member crash when lambda used as a dict key
Pull Request Test Coverage Report for Build 3033283713
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
pylint/checkers/utils.py
Outdated
| @@ -38,6 +38,15 @@ | |||
| nodes.DictComp, | |||
| nodes.GeneratorExp, | |||
| ) | |||
| WITH_IGETATTR = ( | |||
There was a problem hiding this comment.
Isn't it possible to use has_attr("igetattr" and have something generic instead ?
There was a problem hiding this comment.
Sure, I just figured this was more explicit.
There was a problem hiding this comment.
Old python is more duck-type-y, and modern python seems to be more explicit. 🤷🏻♂️
There was a problem hiding this comment.
this was more explicit.
Sure but if another class with igetattr appear we'd need to remember to add it there, which is unlikely to be caught in review, right ?
There was a problem hiding this comment.
That makes sense, will change.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit a2450c6 |
| @@ -1950,6 +1950,8 @@ def is_hashable(node: nodes.NodeNG) -> bool: | |||
| for inferred in node.infer(): | |||
| if inferred is astroid.Uninferable: | |||
| return True | |||
| if not hasattr(inferred, "igetattr"): | |||
There was a problem hiding this comment.
mypy will complain about this when we add py.typed to astroid, but that is a problem to fix then I think.
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Type of Changes
Description
Closes #7453