Suppress OSError in config file discovery

[DanielNoord]

• Write a good description on what the PR does.
• Create a news fragment with towncrier create <IssueNumber>.<type> which will be
  included in the changelog. <type> can be one of: new_check, removed_check, extension,
  false_positive, false_negative, bugfix, other, internal. If necessary you can write
  details or offer examples on how the new change is supposed to work.
• If you used multiple emails or multiple names when contributing, add your mails
  and preferred name in script/.contributors_aliases.json

Type of Changes

	Type
✓	🐛 Bug fix

Description

Closes #7169

[coveralls]

Pull Request Test Coverage Report for Build 3000802112

• 22 of 27 (81.48%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.006%) to 95.328%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pylint/config/find_default_config_files.py	22	27	81.48%

Totals
Change from base Build 2999709475:	-0.006%
Covered Lines:	17017
Relevant Lines:	17851

---

💛 - Coveralls

[DanielNoord]

Coverage is same as on main.

[Pierre-Sassoulas]

Did'nt you say that t contextlib performance were worst than try/except ?

[DanielNoord]

Did'nt you say that t contextlib performance were worst than try/except ?

It is (marginally) I think.

But since this only called once and the code became really unreadable with all the try ... except everywhere I opted for this solution.

Want me to change?

[Pierre-Sassoulas]

Want me to change?

Not at all, just wanted to know your opinion :)

[Pierre-Sassoulas]

I have a feeling this is getting really complicated. Also we're not handling errors. Failing to yield a configuration file because of a permission error will make pylint not take a file into account for non obvious reasons so it seems like we need to do something on top of suppression the error outright.

How about we create some function with explicit name like "get all ini config file" or "search for configuration file in parent directories". That way we can launch a single function in the contextlib.suppresserror or use try/except and maybe decide later what to do easily in case of error.

[Pierre-Sassoulas]

In the issue you're fixing right now the reason is PermissionError: [Errno 13] Permission denied: '/home/myhome/.config/pylintrc', we might want to have a message like "/home/myhome/.config/pylintrc found but is impossible to use because of: PermissionError: [Errno 13] Permission denied: '/home/myhome/.config/pylintrc'"

[DanielNoord]

I have a feeling this is getting really complicated. Also we're not handling errors. Failing to yield a configuration file because of a permission error will make pylint not take a file into account for non obvious reasons so it seems like we need to do something on top of suppression the error outright.

How about we create some function with explicit name like "get all ini config file" or "search for configuration file in parent directories". That way we can launch a single function in the contextlib.suppresserror or use try/except and maybe decide later what to do easily in case of error.

Yeah, I can refactor this into separate functions.

I can also print something to stdout when we are in verbose mode? I don't think warning every time is desired. In the original report this seems like it is a situation the usr can't do anything about. So warning every time would be annoying. Would printing in verbose mode be enough for you?

[Pierre-Sassoulas]

I can also print something to stdout when we are in verbose mode?

Sounds good !

[DanielNoord]

I can also print something to stdout when we are in verbose mode?

Sounds good !

😅

Bit of a chicken and egg. How can we know if we are in verbose mode if we are still looking for a configuration to load...

I would be okay with not doing anything. I think the annoyance of warning about this if you already know about the issue outweighs the issue of silently ignoring.

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 3e67b1f