Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade astroid version following 2.12.3 release #7344

Merged
merged 1 commit into from Aug 23, 2022
Merged

Upgrade astroid version following 2.12.3 release #7344

merged 1 commit into from Aug 23, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✓ ✨ New feature

Description

Refs #6632

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Aug 23, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2911342780

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.304%
Totals Coverage Status
Change from base Build 2907900553: 0.0%
Covered Lines: 16926
Relevant Lines: 17760
💛 - Coveralls

@Pierre-Sassoulas
Copy link
Member Author

Do you know why primer fail (consistentely) @DanielNoord ?

@DanielNoord
Copy link
Collaborator

Do you know why primer fail (consistentely) @DanielNoord ?

Ah yeah, I didn't think about this. Since only main can create new venv environments any PR that updates dependencies won't be able to prime.
I'll try and think of a solution but for now I think it's okay to just merge this as long as the tests pass.

@Pierre-Sassoulas
Copy link
Member Author

All right, let's merge then 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit dcd2b17 into pylint-dev:main Aug 23, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the upgrade-astroid-to-2.12.3 branch August 23, 2022 19:45
@DanielNoord DanielNoord mentioned this pull request Aug 25, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pierre-Sassoulas @coveralls @DanielNoord