Allow lists of default values in parameter documentation for Numpy
#7149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
Needs backport
Pierre-Sassoulas
approved these changes
Jul 8, 2022
Pull Request Test Coverage Report for Build 2638482339
💛 - Coveralls |
It's also that some of these regexes are really quite bad. Using both f-strings and regular expressions from different classes and in different recursive patterns is awful to work with. You can't easily copy them to |
|
🤖 Effect of this PR on checked open source code: 🤖 Effect on pandas:
The following messages are no longer emitted:
This comment was generated for commit 73c5197 |
|
Outch should have waited for the primer, before approving. |
|
They are actually good! Just turns out we're not fully supporting Numpy just yet. But the number of messages or missing parameters is going down! See the difference between the first two. I'll make an issue about remaining issues. |
|
Hmm right, we have most message with actually a more accurate message with one param that do not warn anymore. This is why we need the better primer diff, I need to do it from scratch again though 😄 |
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
pushed a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Jul 17, 2022
Pierre-Sassoulas
pushed a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Jul 17, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
Closes #4035.
I really don't want to talk about the number of hours it took me to get this regex right. The fact that I assigned this to myself in October is a small indication...